Do not bypass task generation when version changes #7890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathyushpv
approved these changes
Jun 10, 2025
Shivs11
pushed a commit
that referenced
this pull request
Jun 10, 2025
## What changed? Server sends new wft in response of preious wft completion. This should not happen if the next wft is supposed to go to a different worker version. ## Why? When there is a transition, workflow could fall into an infinite loop of workflow tasks because they never go to the right worker. ## How did you test it? - [ ] built - [ ] run locally and tested manually - [ ] covered by existing tests - [ ] added new unit test(s) - [ ] added new functional test(s) will be verified in Nightlies. ## Potential risks None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Server sends new wft in response of preious wft completion. This should not happen if the next wft is supposed to go to a different worker version.
Why?
When there is a transition, workflow could fall into an infinite loop of workflow tasks because they never go to the right worker.
How did you test it?
will be verified in Nightlies.
Potential risks
None